Pandora-IsoMemo / DSSM

Pandora & IsoMemo spatiotemporal modeling (DSSM)
https://pandora-isomemo.github.io/DSSM/
GNU General Public License v3.0
4 stars 1 forks source link

Missings assign r refactored #179

Closed arunge closed 1 year ago

arunge commented 1 year ago

@mgross

  1. The check failed because the new package "mice" was missing in the description file
  2. It was very hard to follow the many if-else-clauses. That is why, I needed to refactor the code a bit in order to get the logic. I extracted some functions, but did not change the logic of the imputation. This should make the code easier to follow. Could you please check the refactoring and if the logic is still correct? Do you have any test data (or columns from the isomemo data that contains missing values) to test the new feature?

When we merged the refactoring into your branch we can continue with your PR.