Pandora-IsoMemo / DSSM

Pandora & IsoMemo spatiotemporal modeling (DSSM)
https://pandora-isomemo.github.io/DSSM/
GNU General Public License v3.0
4 stars 1 forks source link

Check map centering for Modeling: atlantic and pacific center #180

Closed arunge closed 9 months ago

arunge commented 1 year ago

Regarding:

A map centred in the Pacific should be generated in a similar way as a map centred in the Atlantic. After all, this is just a transposition/re-centring along the x-axis.

I probably have asked this previously, but why cannot the following be done:

1) When the user selects the option to centre in the Pacific one keeps using the "Atlantic" modelling approach but one redefines the x variable as x' variable which is simply transposed by 180 degrees (or the equivalent in whatever unit you are using). That is: x' = x +180

2) The modelling is now done on x' as it would be done on x

3) Once the results are generated transpose these back so that display correctly for the Pacific

Originally posted by @isomemo in https://github.com/Pandora-IsoMemo/iso-app/issues/175#issuecomment-1630375477

Additional notes:

arunge commented 1 year ago

@f-lukas Please, let us discuss how we could find a better solution.

isomemo commented 1 year ago

@arunge @f-lukas I just want to add that transposition may not be as I described above since there is a projection into a plane of a spheric-like system. However, there would be some function that does this.

mgross commented 1 year ago

The reason why it's not just transposed by 180 degrees is that if you have data covering the whole world you would have a problem at the atlantic border nontheless, which is nondesirable, too. How it is currently implemented is that it creates mirrored pseudo data at all 4 borders, such that in effect we don't see a boarder anymore. (still can be seen for the Bayesian case with not so much iterations, but this is due to random fluctuations: with enough iterations this will be not visible).

The spherical modelling is actually faster than the planar one with mirrored data.

160 degrees instead of 180 because then europe is not cut in the global map.

arunge commented 1 year ago

I have added a detailed description of the features that are related to map centering to the wiki of this repository. For this, very helpful input was provided by @mgross.

@isomemo please, let us discuss based on the current logic how to continue here.

arunge commented 12 months ago

@isomemo Today we discussed the issue of centering the map. Following points came up:

At the end the question came up if we could just remove the option for a planar modeling and always use the spherical modeling.

@mgross Is there any reason to keep planar modeling? Do you know typical use cases when planar modeling should be used instead of sperical modeling?

arunge commented 9 months ago

Today, @mgross @isomemo and @arunge discussed that

@mgross and @arunge will discuss the details regarding the implementation of the transformation next week.

However, currently implementation of the transformation will not have priority!

arunge commented 9 months ago

This issue will be continued within the new task:

I am closing here.