OperatoR inputs

[isomemo]

Currently in OperatoR inputs we can select "Data source" and "Select map". However, if I select under "Data source" the option "Save map" no listing is given under "Select Map". This only works if for "Data source". I select "Create map".

I believe that the option the option "Save map" is relative to the creation of maps which is now under of the main menu "Saved maps". This generates considerable confusion. To clarify:

1) In the main menu rename "Saved maps" to "View/create single maps" 2) Under OperatoR. "Data source" as "Create map". In fact, you can drop altogether the first pending list since there is only one single option. You can add the title "OperatoR: map operations". 3) The progression bar shows "Creating difference map" irrespective of operation being run. This should read only "Creating map"

[mgross]

The saved map option under data options is for maps that were already created and saved with OperateR (to re-view them).

[isomemo]

Ok! Then we leave it as is but still we need the following:

In the main menu rename "Saved maps" to "View/create single maps" since the creation of "numeric" maps is done under this menu. It is not only for viewing.

Under this menu, the option to create a rectangle (now named square, please correct naming) and given input boxes for lat/long of upper left/lower right rectangle. Now showing option for circle.

In OperatoR, the progression bar shows "Creating difference map" irrespective of operation being run. This should read only "Creating map"

[jroachell15]

@mgross have you already helped @isomemo on this issue or should i make the name changes?

[mgross]

@jroachell15 If you can do this I would be grateful

[jroachell15]

@isomemo

i have changed the saved maps to View single map:

also

now when performing the run, the progressing the bar shows now "Generating map" instead of "Generating difference map"

is there anything else you want to change?

[isomemo]

@jroachell15

In the main menu:

Rename "Saved maps" to "Saved/Create maps"

Once you select the above you have the following inputs:

If I select "region - circle" it makes sense then to select a "Radius in km" and "Set Latitude center" and "Set Longitude of center". That is, it draws a circle of a certain radius for a selected centre. However, I I select the option "region - square" I have the same options. Obviously, I cannot set a radius for a square. So, first please clarify how is the square is being drawn? Once I know this, we can rename the inputs accordingly.

Also, for the above, instead of a scroller to select the "Radius in km" please have an input box.

Under OperatoR:

The option "Saved maps", I noticed, only loads maps saved under OperatoR, so best to rename this as "Load OperatoR map" instead of "View single map" as previously suggested.

[arunge]

@jroachell15 I found another issue where name changes regarding the saved mapes are requested: https://github.com/Pandora-IsoMemo/iso-app/issues/20

Could you check which one is more up-to-date or if there is something new mentioned here:

Under the main menu currently named "Saved maps" I can create new numeric maps. If I select the option region-circle, I can select to create a numeric map for a certain radius around a certain centre. This seems to be Ok. However, if I select the option region-square the options are the same. This should be renamed as region-rectangle. Here, the options should be the upper left/lower right corners of the rectangle area to defined with respective lat/long inputs.

If https://github.com/Pandora-IsoMemo/iso-app/issues/20 is now only a duplicate of this one, feel free to set the "duplicate" label and to close https://github.com/Pandora-IsoMemo/iso-app/issues/20.

[jroachell15]

@isomemo

• [x] change to Saved/create maps.

If I select "region - circle" it makes sense then to select a "Radius in km" and "Set Latitude center" and "Set Longitude of center". That is, it draws a circle of a certain radius for a selected centre. However, I I select the option "region - square" I have the same options. Obviously, I cannot set a radius for a square. So, first please clarify how is the square is being drawn? Once I know this, we can rename the inputs accordingly.

• This I don't know, maybe @arunge has some knowledge on this?

Also, for the above, instead of a scroller to select the "Radius in km" please have an input box.

• [ ] this might take some time from Timebank from testing.

• [x] The option "Saved maps", I noticed, only loads maps saved under OperatoR, so best to rename this as "Load OperatoR map" instead of "View single map" as previously suggested. DONE.

[isomemo]

@mgross @arunge @jroachell15 Marcus should be able to quickly clarify how the square is being created. Following this, you will just need to update labels.

[mgross]

It is the side length of the square (at the center latitude)

[jroachell15]

@isomemo are there anymore naming changes you want?

[isomemo]

@mgross @jroachell15 Yes, we will have to change the naming for when a square is selected. However, before doing that, I would like to ask Marcus if it would be easy to have a rectangle instead of square? Can you please show to Jian the code that would need to be updated for a rectangle option? In this, case one would define a width and height.

Also, be it a circle, rectangle, or square have you considered the possibility that a figure, if too large, could cross the lat/long map limits?

[jroachell15]

@isomemo

For this: change the naming for when a square is selected. However, before doing that, I would like to ask Marcus if it would be easy to have a rectangle instead of square? Also, be it a circle, rectangle, or square have you considered the possibility that a figure, if too large, could cross the lat/long map limits. For the above, instead of a scroller to select the "Radius in km" please have an input box.

This seems to be more than just changing names, maybe we start a new issue for this and save that for the next contract or use the timebank? thanks!

[isomemo]

@jroachell15 @mgross I was indeed planning to use the support contract to change from square to rectangle implementation but it would be more efficient if Marcus just flags the code where the inputs are given and replies to my previous queries. Then, we can set a different item for the rectangle implementation and complete the renaming.

[arunge]

@jroachell15 I merged your current name changes into the beta. Please open a new feature branch for other tasks of this issue.

[arunge]

I will check open tasks here and update the ticket next.

[arunge]

The code that takes the inputs (1), (2), (3):

can be found here:

https://github.com/Pandora-IsoMemo/iso-app/blob/c860d9585829c536883b5aa9942541370753ab84/R/04-savedMapsModule.R#L28-L46

and input$userMapType correspond to: https://github.com/Pandora-IsoMemo/iso-app/blob/c860d9585829c536883b5aa9942541370753ab84/R/04-savedMapsUI.R#L21

@isomemo Should the slider "Radius in km" be renamed to "Length in km" if "region-square" is selected?

@mgross As far as I understand the formula:

pmax(abs(coord[,2] - input$centerLatitude), abs(coord[,1] - input$centerLongitude)) < input$userRadius / 111

"Radius in km" should be here half of the length of the square side. Is that correct?

If so, one could easily half the value of a new input "Length in km" only for the square case, and will get the same result.

For the additional rectangle option I would create a new ticket afterwards.

[isomemo]

@arunge see my comments above. It should be rectangle (not square) and the user would give two coordinates points (upper left and lower right corners). With this is there is no need to input a length.

[arunge]

@isomemo as discussed I will implement this and give it into review to @mgross .

---

This is part of:

Saved Maps tab

From https://github.com/Pandora-IsoMemo/iso-app/issues/20 Under the main menu currently named "Saved maps" create new numeric maps. If the user selects the option region-circle, one can select an option to create a numeric map for a certain radius around a certain selected location center. This is already implemented and works well. However, if a user selects the option region-square the options remain the same. This option should be renamed as region-rectangle. Here, the modelling options should be the upper left/lower right corners of the rectangle area to defined with respective lat/long inputs.

Originally posted by @arunge in #69 (comment)

[arunge]

With version 23.01.2 of the isomemo app beta I added the rectangle option and updated the UI of saved/create map.

@isomemo As discussed, please test the feature since I tested it only with test data and not together with real maps. Maybe we could rename the button (1) to something like "Create map template"?

[arunge]

@isomemo There was a post in https://github.com/Pandora-IsoMemo/bmsc-app/issues/18#issuecomment-1447971616 from you:

@arunge creation looks Ok! But I need to test Operations to be certain this is working well!

One thing I did notice is that there is no Type information being given (I tried the rectangle option)

Possibly it belongs to this issue. If so, what kind of Type (1), (2) should be used for the templates?

[isomemo]

@arunge I think that probably best to use "Shape vector"

[arunge]

@isomemo With version 23.03.5 I added the label (1) to the type column on iso-app beta:

All is done here.