Pandora-IsoMemo / OsteoBioR

Temporal Estimation of Isotopic Values (OsteoBioR)
https://isomemoapp.com/app/osteobior
GNU General Public License v3.0
0 stars 0 forks source link

Export of plot results: add sampling of y values #52

Open arunge opened 2 months ago

arunge commented 2 months ago

.. Except of one left point all other features are implemented with version 24.04.1 ...

  • In the export of plot results include columns for: ...
    • [ ] Users can use default options or select a temporal resolution (x-axis) for sampling of y values.

Originally posted by @arunge in https://github.com/Pandora-IsoMemo/osteo-bior/issues/43#issuecomment-2077109882

arunge commented 1 month ago

I believe I need more information to continue here.

Currently, the export of plot results includes following columns, for example:

image

@isomemo, to be precise: With changing the temporal resolution (x-axis) you mean to change the values in the column time and to obtain new values for lower, median, upper, sd columns for new time values, correct?

@mgross, is it correct that we would need to re-run the model in order to obtain samples for a different temporal resolution, that means different values of time? As far as I see, the model takes values e.g. for tooths and bones for each point of time:

input data example:

image

function call:

https://github.com/Pandora-IsoMemo/OsteoBioR/blob/1921c1f8d02a0829dc5470390f872e185f270b6e/R/estimateIntervals.R#L190-L206

It returns samples for each of the time values given in the input data. That is, if we have different time values than in the input data, we need to re-run the model, correct? Is it possible at all to get samples for time values for which we do not have any values of e.g. tooths or bones? If so, how? Or can we only filter the time values that are available from the input data? (Which would mean that we could only decrease the given temporal resolution.)

arunge commented 2 weeks ago

Today I discussed this issue with @isomemo

Currently, after running the model, we do obtain samples for each row of data (time point, e.g. with intStart and intEnd). From these samples we get lower, median, upper, sd values for each time point (compare above tables).

We would like to have the option to obtain samples from e.g. a time point between to time points from the input data without having to re-run the model.

@mgross How can we obtain these samples? For example for a time between time = 2.5 and time = 3.5 from the table above, let's say for time = 3.1?

If you have questions, just let me know or write me via Slack. :slightly_smiling_face: