Pandora-IsoMemo / ReSources

Food Reconstruction Using Isotopic Transferred Signals (ReSources)
https://pandora-isomemo.github.io/ReSources/
GNU General Public License v3.0
0 stars 1 forks source link

version 22.08.2 - Bug/44 conflicts with column names #51

Closed arunge closed 2 years ago

arunge commented 2 years ago

version 22.08.2

arunge commented 2 years ago

@jroachell15 I fixed mismatches between column names of targets and list names for source. Data was actually not "deleted", but when changing the column names of targets, this was not updated in the list object containing the sources data. That is why, the app couldn't find sources under any new column names.

Can you check if my fix solves the problem, and if the bug from point 3 in #44 is not occuring anymore?

I tried to prepare a rather long model yesterday, all seemed to be working well until I reached the stage of entering data for concentrations. Once I did this there was an automated update for the tables under Sources. These tables were assigned zero columns and my data was deleted. I tried today a different model and the same happened again. This time I made a recording so that you could reproduce all inputs. The issue is shown around minute 7:

If all is fine here, I will first add additional tests before merging. I restructured the code behind the data tabs. To be more certain that results remain the same, I will add some tests to the main branch which must be passed also here before I merge.

arunge commented 2 years ago

I merged new tests from the main and beta branch into this feature branch. All tests are succeeding currently.

However, before merging here, I will add tests that will check if the modularising of the tabs targetValues, components, sources, concentrations broke something or if the result remains the same.

Just to be sure that the app will still work as expected.