Pandora-IsoMemo / ReSources

Food Reconstruction Using Isotopic Transferred Signals (ReSources)
https://pandora-isomemo.github.io/ReSources/
GNU General Public License v3.0
0 stars 1 forks source link

ReSources: Integrate the new module to import data #70

Closed arunge closed 1 year ago

arunge commented 1 year ago
arunge commented 1 year ago

The beta version of Resources 23.02.2 now uses the import module with Pandora/url access and merge/query feature.

@isomemo or @CarloCocozza Could you please check carefully if import of data is working as expected. It was quite challenging to integrate the checks (that were used before) into the new module. I had to add extra functionality to the import module because of batch imports and because Resources expects output being a matrix. Could you try typical and not typical data and tell me if the app crashes or if the error messages are fine?

isomemo commented 1 year ago

@arunge @CarloCocozza did you test this?

CarloCocozza commented 1 year ago

@arunge I am sorry, I might have missed this email.

@isomemo I am not aware what this is about. Maybe we can check this together later.

isomemo commented 1 year ago

@arunge I am checking ReSources beta and the input of files is the old one. Not the Pandora module.

arunge commented 1 year ago

@isomemo Are you talking about the online version? I do have access to the very new impurt module (3) :thinking:

image

Could you try to clean your cache of the browser please?

isomemo commented 1 year ago

@arunge

This is really strange. This is what I get:

image

arunge commented 1 year ago

@isomemo Did you maybe use the "Browse" input (1)? This is only for upload of .zip files containing a saved model. There I did not add the import module. Since the Import-Module does not understand .zip files. We would need to add this functionality of uploading a model and transferring all inputs to the app. Until now, I even did not think about this option. Is this required?

If yes, we must talk about the implementation.

I only added the import module to the buttons where it is possible to upload tables from .csv or xlsx, e.g. (2), (3)

image

image

isomemo commented 1 year ago

@arunge Yes, it should work for the Browse input here and for other apps! It should work for any type of uploaded files. However, only for certain types of files (e.g., txt, csv, Excel) will there be a data preview and data merger.

Remember also that this should work for saved SQL queries.

arunge commented 1 year ago

@isomemo Regarding

Yes, it should work for the Browse input here and for other apps! It should work for any type of uploaded files. However, only for certain types of files (e.g., txt, csv, Excel) will there be a data preview and data merger.

Remember also that this should work for saved SQL queries.

this will be developed within

So, I am closing here.