Update error messages coming from modelling - Githubissues

Pandora-IsoMemo / ReSources

Food Reconstruction Using Isotopic Transferred Signals (ReSources)

https://isomemoapp.com/app/resources

GNU General Public License v3.0

0 stars 1 forks source link

Update error messages coming from modelling #87

Closed arunge closed 12 months ago

arunge commented 1 year ago

Regarding

@arunge Ok for now!

I wanted to check how errors from modelling are caught in the other apps: ...

[x] Resources
- [x] some default error messages
- [x] error messages forwarded directly from the function

...

@isomemo I will open a separate issue for missing try-catches and close here.

Originally posted by @arunge in https://github.com/Pandora-IsoMemo/bmsc-app/issues/18#issuecomment-1468326275

arunge commented 12 months ago

Current situation:

Running the model should not lead to an app crash, because:

Errors are caught at following positions when trying to create a model object and when trying to run the model:

If modelling fails, informative messages will be prompted. A lot of logic is covered here: https://github.com/Pandora-IsoMemo/resources/blob/3f3b8082c384b1faeae97e6c73014078d534cb2e/R/04-runModel.R#L24-L49

If nimble fails itself, the error is prompted: https://github.com/Pandora-IsoMemo/resources/blob/3f3b8082c384b1faeae97e6c73014078d534cb2e/R/04-runModel.R#L109-L113

Errors inside shinyInputToClass may occur if trying to select an object that does not exist, e.g. ": Indexing out of bounds"

[x] However, some post-processing of results is done afterwards. Here, we need to add some try-catches to prevent app crashes: