search

Pandora-Labs-Org / erc404

396 stars 185 forks source link

centralize validValueOrId check #19

Open mathdroid opened 8 months ago

mathdroid commented 8 months ago 
          just an idea, not needed for this version: this logic could be a function since we reuse it everywhere, it's critical, and when we want to support burning it will need to be changed in many places.

_Originally posted by @caldereth in https://github.com/Pandora-Labs-Org/erc404/pull/17#discussion_r1487190473_

aruns05 commented 8 months ago

@mathdroid is this being worked upon ?

mathdroid commented 8 months ago

it should already be in the current impl. closing after confirmation @0xacme @caldereth

gaavar commented 8 months ago

I think that the _isValidTokenId implements this and is present in the main branch.

aruns05 commented 8 months ago

Is there any other good first issue,interested in contributing