search

Pandora-Labs-Org / erc404

402 stars 186 forks source link

Any plan to submit this 404 standard to the EIPs repo? #29

Open sorawit opened 9 months ago

sorawit commented 9 months ago

I'm curious whether Pandora team plans to submit this hybrid ERC20+ERC721 standard to the EIPs repository. Currently, there's some confusion about the final function interfaces and events, as well as the rationale behind them (some of which have changed from the legacy implementation). Without an official standard, it becomes particularly challenging for other projects to, for instance, implement their own 404 smart contracts with different performance tradeoffs while ensuring consistency with the specification. Also difficult for wallets, indexers and exchanges to know what data to read.

In the current codebase, the event Transfer(...) and event Approval(...) have been completely removed. Do we expect Etherscan, wallets, and other indexers to track the new ERC20Transfer, ERC20Approval, ERC721Transfer, etc., events? Otherwise I don't think token balances won't show on Web3 wallets / and contract won't be recognized as token on Etherscan.

I'm willing to assist with the draft if there are plans to proceed. Any information would be greatly appreciated.

sorawit commented 9 months ago

Seems like a merge ~2 hours ago just changed the spec https://github.com/Pandora-Labs-Org/erc404/pull/17 for events back to be the conflicting signatures again. Having spec would be great!

0xacme commented 9 months ago

Getting there 👍

I'll leave this open for the time being as it does deserve visibility. Just want to acknowledge.