search

Pandora-Labs-Org / erc404

401 stars 186 forks source link

minor enhancement: make ```_storedERC721Ids``` internal #45

Open gaavar opened 9 months ago

gaavar commented 9 months ago

Motivation

This pull request is for addressing this issue.

The change makes it easier for developers to build features by accessing variable _storedERC721Ids as part of an inherited contract.

Change Summary

The change in this PR switches _storedERC721Ids access modifier from private to internal.

gaavar commented 9 months ago

@mathdroid could I please get a review on this?

p-dealwis commented 9 months ago

this is a good change, otherwise the contract that extends off this will have to instantiate it again if they want to override methods that use it like _withdrawAndStoreERC721