Enable to use a BottomNavigator scoped to a Fragment and tied to its child FragmentManager

PandoraMedia / BottomNavigator

Android Bottom Navigation multiple stack manager

Apache License 2.0

305 stars 22 forks source link

Enable to use a BottomNavigator scoped to a Fragment and tied to its child FragmentManager #26

Closed qnga closed 8 months ago

qnga commented 3 years ago

Hello!

I've added the ability of properly using a BottomNavigator inside a Fragment instead of an Activity. It implies to execute transactions with the Fragment's child FragmentManager, tie the execution of commands to its lifecycle and scope the BottomNavigator instance to its ViewModelStore.

For the sake of simplicity and backward compatibility, I've overloaded a few methods with alternatives that take a Fragment in argument.

This PR would fix #13.

qnga commented 3 years ago

I'm not sure which unit tests I should replicate with Fragments. BottomNavigator.onCreate is just a public wrapper I can't find specific tests for.
A nested BottomNavigator would look quite weird, wouldn'it? Rather, I would have thought of a different Activity. For testing purpose it might be fine though.
I made a try. Is it enough?