Closed andresailer closed 7 years ago
Looking at the LAREventWritingAlgorithm, it does not inherit from the SDK EventWritingAlgorithm. Did you ( @PandoraPFA ) not mean literally inherit, but inherit by copy-and-paste?
There's no good reason why this didn't happen - it should have. If you're not trying to do anything too ambitious, i.e. just register some new factories, then inheriting most functionality should ease future maintenance and improve clarity. I can't recall the original decisions for LArEventWriting/Reading, but these algorithms (esp. Reading) do have some additional goals and complexities.
Solved by #18
https://github.com/PandoraPFA/LCContent/pull/16#discussion_r140034006
https://github.com/PandoraPFA/LCContent/pull/16#discussion_r140593664