search

Paneedah / paneedah-modern-warfare

Apache License 2.0
30 stars 8 forks source link

Updated package name #58

Closed BurnhamR closed 1 year ago

BurnhamR commented 1 year ago

WARNING ! This will break all current forks and pull requests!

You must sync your repo before making any future pull requests!

Desoroxxx commented 1 year ago

Huh this will probably create a shit ton of mod incompatibility

Desoroxxx commented 1 year ago

Any mod you try to detect if the main class is here will not find it and throw a class not found exception, this might be harmless for some mods. Or can break the compat they add. Worst case scenario it's gonna corrupt world.

My biggest concern with this is it breaks any add-on that exists

Paneedah commented 1 year ago

It should be fine, Ive tested it in 3 small-medium sized modpacks that use Vic's and it seems to not have impacted anything and still works.

Worst case scenario, this may need to be reverted in case there is any weird add-ons that have funny interactions with VMW, I do advise for developers to use the official method for detecting the mod though as detecting the main class directly isn't the best way to do it at all.

Desoroxxx commented 1 year ago

Detecting with the official way is not possible for some mods.

But actually now that I am thinking about it if a mods needs it we can just add an empty class either the main class name with the same package as the old one

Paneedah commented 1 year ago

Yeah we could just do that as well.