search

Panenco / papi

MIT License
2 stars 0 forks source link

ListRepresenter, Representer and ArrayRepresenter should be in same file #8

Open driescroons opened 2 years ago

driescroons commented 2 years ago

I feel like we should the representers in 1 single file with different exports. They're small files, so why not?

ljobse commented 2 years ago

What's the benefit?

driescroons commented 2 years ago

cleanup

ljobse commented 2 years ago

Goes against the general naming conventions I'd say. Usually I'm not a fan of having multiple things in one file. It would add the "complexity" of always having to choose if things should be combined or not, naming can become unclear, locating certain things can become more difficult.

In some cases I agree it would make sense to group items but it doesn't way up to the downsides. So I rather keep it consistent