PanicInitiative / PanicButton

Panic Button turns your mobile phone into a secret alarm for when you're in trouble
https://panicbutton.io
GNU General Public License v3.0
200 stars 99 forks source link

Remove Disguise Trigger screen #187

Open jmatsushita opened 8 years ago

jmatsushita commented 8 years ago

Remove the training for the Calculator trigger (just after the power button training).

Both in the initial install and when redoing the training.

(However do not remove the calculator trigger feature only the training screens)

niccs commented 8 years ago

Hi @jmatsushita ,

there are three steps-- 1)Power button trigger training. 2)Disguise alarm trigger training 3)Disguise unlock training(long press and unlock)

Currently I have removed Step-2. Do you want me to remove Step-3 also?? In redo Training after advanced settings change , only step -1 is followed.

And there are two app flows:-- 1) App fresh install 2) app update install of 1.5 version.

In both the flows I am assuming same changes to be done. Please clarify

jmatsushita commented 8 years ago

Hi @niccs,

This issue is fine and working good on a fresh install! But on update only Step 1) Power button trigger training needs to be launched.

niccs commented 8 years ago

Hi @jmatsushita ,

1) For update flow, I have changed to configure separate set of json objects , so as to play step-1 for training.

2) Regarding the indefinite display of Toast msg in calculator screen:--

Only long duration(3.5 secs) or short duration(2 secs) is permitted from anfroid API. Right now I have used Long delay, which is used everywhere in app during training screens.In case we want to increase the duration more, I need to customize the implementation of toast class.

Let me know , if that is required.