PanicInitiative / panicbutton.io

Website
http://panicbutton.io
7 stars 8 forks source link

Work out what's going on with the Download PDF button. #5

Closed jmatsushita closed 8 years ago

jmatsushita commented 8 years ago

The original doesn't have a button (anymore): http://the-engine-room.github.io/PACT-kit/pact%20activities/Introduction/

The current merge has a button that doesn't work. http://iilab.github.io/teampanicbutton.github.io/pact-activities/pact-activities-01-introduction.html

Note that the pdf folder has not been merged yet (and probably should be).

naturalshine commented 8 years ago

The PDF button, on clicking, calls a function [ fromHTMLtoPDF() ] that doesn't exist yet. I suspect this is why it's been removed on the original -- someone didn't get around to writing the functionality. I can add writing a function to do this onto my list if you'd like.

jmatsushita commented 8 years ago

Thanks for the analysis! Maybe we can first replace the PDF button to a link to the corresponding PDF in the pdf folder for now?

naturalshine commented 8 years ago

Ah yes, that's the best solution :) Will do

naturalshine commented 8 years ago

@jmatsushita This is also fixed, with the button linked to the correct PDF, as we discussed.

jmatsushita commented 8 years ago

Oops... I'm getting something weird when opening in the browser:

image

When opening in Adobe Reader there's further insights about what might be going on:

image

naturalshine commented 8 years ago

Ahh, weird. I think this must have been some glitch; the pdf's are looking fine to me upon regeneration of the site, both from the "download PDF" button, and in the .zip files of the game/ training kit. Of course, upon regeneration of the PDFs with new content, this will need to be checked again.