Closed yashasvini121 closed 9 months ago
don't use bytes as a return type , just work with strings
By the way , did you use any AI tool to generate the code ?
No, I used the code from the base45 python module, and a golang based program code for the base62 task. I hope that doesn't disqualify my code. The fxns return string, I had not updated the return type annotations, my bad
okay can you send those python and golang code , I'm not disqualifying this but have a bit doubt Actually your code is too much professional for beginner friendly open source contest
I think you send wrong link ! , base45 code is not even initialized in that code , just used library function to encode or decode
no it is, in the __init__
file, https://github.com/kirei/python-base45/blob/main/base45/__init__.py
you need to change the code at least , you can use another's algorithm but cannot submit as it is , sorry cannot merge this pr if you need more time then take your time but don't just submit like this Or if you have any doubt about the algorithm then you can also ask us (mentors) for this Sorry for the rejection , hoping better outcome from you
Ok, no problem, I will change the code.
Hi @Pankaj0038 , could you please review my pr and tell me if any improvements are required.
that's fine , well done @yashasvini121
Resolving issue #45 Adding the encoder and decoder functions for Base45 and Base62