Pankaj0038 / dcodeKi

Python GUI based encoder-decoder tool
https://pankaj0038.github.io/dcodeKi/
8 stars 18 forks source link

Adding base45 and base62 #63

Closed yashasvini121 closed 9 months ago

yashasvini121 commented 9 months ago

Resolving issue #45 Adding the encoder and decoder functions for Base45 and Base62

Pankaj0038 commented 9 months ago

don't use bytes as a return type , just work with strings

Pankaj0038 commented 9 months ago

By the way , did you use any AI tool to generate the code ?

yashasvini121 commented 9 months ago

No, I used the code from the base45 python module, and a golang based program code for the base62 task. I hope that doesn't disqualify my code. The fxns return string, I had not updated the return type annotations, my bad

Pankaj0038 commented 9 months ago

okay can you send those python and golang code , I'm not disqualifying this but have a bit doubt Actually your code is too much professional for beginner friendly open source contest

yashasvini121 commented 9 months ago

Ok, https://github.com/kirei/python-base45 and https://medium.com/@anabhishek.jha/base-62-text-encoding-decoding-b43921c7a954

Pankaj0038 commented 9 months ago

I think you send wrong link ! , base45 code is not even initialized in that code , just used library function to encode or decode

yashasvini121 commented 9 months ago

no it is, in the __init__ file, https://github.com/kirei/python-base45/blob/main/base45/__init__.py

Pankaj0038 commented 9 months ago

you need to change the code at least , you can use another's algorithm but cannot submit as it is , sorry cannot merge this pr if you need more time then take your time but don't just submit like this Or if you have any doubt about the algorithm then you can also ask us (mentors) for this Sorry for the rejection , hoping better outcome from you

yashasvini121 commented 9 months ago

Ok, no problem, I will change the code.

yashasvini121 commented 9 months ago

Hi @Pankaj0038 , could you please review my pr and tell me if any improvements are required.

Pankaj0038 commented 9 months ago

that's fine , well done @yashasvini121