search

Panopto / Moodle-2.0-plugin-for-Panopto

Panopto's integration with the Moodle LMS.
http://www.panopto.com
GNU General Public License v3.0
18 stars 38 forks source link

API error breaks moodle grading screen #172

Closed yao9394 closed 7 months ago

yao9394 commented 3 years ago

There is chance that Panopto server is up, but for some reason sync_external_user could be broken, for example, some issue with database which could break sync_external_user and return 500 error and there is no try catch block. As this is called when initialising atto editor that has enable panopto button, that breaks grading screen.

We should add try catch block for these lines

https://github.com/Panopto/Moodle-2.0-plugin-for-Panopto/blob/master/lib/panopto_data.php#L775-L784

example: https://github.com/Panopto/Moodle-2.0-plugin-for-Panopto/blob/master/lib/panopto_data.php#L445-L455

jmalmsten-panopto commented 3 years ago

Hi @yao9394 ,

I have filed an internal work item to track this issue, the reference number for the internal work item is 73003. If you require future support please feel free to open a support ticket at support.panopto.com.

Thanks, Joe Malmsten

TomoTsuyuki commented 2 years ago

Hi,

I pushed the update for this issue.

Please review and merge if it's ok.

Kind regards, Tomo

zeroAps commented 7 months ago

This issue should be fixed. Closing this for now.