search

Panopto / Moodle-2.0-plugin-for-Panopto

Panopto's integration with the Moodle LMS.
http://www.panopto.com
GNU General Public License v3.0
18 stars 38 forks source link

Code cleanup #185

Closed aurelienb1 closed 1 year ago

aurelienb1 commented 2 years ago

Hi,

It would be interesting to clean up the code to comply with Moodle standards.

The CodeChecker plugin helps with this task, there is a lot of whitespace, too much space and too long a string.

Another point, what is the point of depending on mod_forum (version.php) since null by in the code there is a call to a class or function of the forum or maybe I have seen wrong.

Regards

jrchamp commented 2 years ago

Related: #178

jmalmsten-panopto commented 2 years ago

Hi,

I have filed an internal work item to to clean up the block and bring it in line with Moodle standards. I'm not able to directly merge the suggested pull request into our repository, but will take a look at it and can open an internal PR for those changes once we get to this item.

I've also filed an internal item for the mod_forum dependency. Once we confirm that is not needed, I'll make sure it gets removed in a future release.

Thanks, Joe

jmalmsten-panopto commented 1 year ago

Hi,

This issue should be fixed with the latest release. We have also added Github actions to the plug-in.

Thanks, Joe