search

Panopto / Moodle-2.0-plugin-for-Panopto

Panopto's integration with the Moodle LMS.
http://www.panopto.com
GNU General Public License v3.0
18 stars 38 forks source link

SessionManagementWsdlClass.php __set_state doesn't adhere the php 8.0 method signature #190

Closed okigye closed 1 year ago

okigye commented 2 years ago

Hello!

In https://github.com/Panopto/Moodle-2.0-plugin-for-Panopto/blob/9a859fc7a0b2f72079f62a1feedd831a5fba171a/lib/SessionManagement/SessionManagementWsdlClass.php#L256 the signature of the SessionManagementWsdlClass's __set_state function is (array $_array,$_className = CLASS) which doesn't matches the signature public function __set_state(array $properties): object {} This causes fatal error. See php documentation: https://php.watch/versions/8.0/magic-method-signatures

Thanks for your help. Okigye Ps. I'm sorry if i'm sounding rude, or terse, English isn't my first language.

michaelwayneharris87 commented 1 year ago

Is there an estimate for when this issue will be resolved? We are also getting this issue.

jrchamp commented 1 year ago

Looks like this was fixed 15 days ago.

jmalmsten-panopto commented 1 year ago

Yes, this issue was fixed with the last release. I will be closing this ticket now!

Thank you for your patience, Joe Malmsten