Panopto / Moodle-2.0-plugin-for-Panopto

Panopto's integration with the Moodle LMS.
http://www.panopto.com
GNU General Public License v3.0
18 stars 38 forks source link

permissions are not changed on enrollment suspension / reactivation #62

Closed Syxton closed 7 years ago

Syxton commented 8 years ago

Fixed in https://github.com/Panopto/Moodle-2.0-plugin-for-Panopto/pull/60

Syxton commented 8 years ago

Could you look at https://github.com/Panopto/Moodle-2.0-plugin-for-Panopto/pull/60/commits/9b7bff28d825ebdff23ae2aa71aff19122c948bb and see if this could be used. Thanks!

hohno-panopto commented 8 years ago

Thank you for suggesting the fix, @Syxton

We looked at this specific commit 9b7bff2 (but not entire pull request #60 ). We understand that this resolves your problem. However, this seems to have side effect to some other users who have the case that a single Moodle user has multiple roles and one of these roles may be stripped individually. Therefore, this commit may not be taken as-is to our master branch.

Assuming the issue you want to solve here is what happens with our released plug-in (not specific to your cron job), could you open a support ticket to our support team and make us understand the exact scenario and get the local repro on our side? (Or if you already did so, could you tell me ticket number?)

Thanks again for your help and contribution to our product.

Syxton commented 8 years ago

This specific commit I am concerned about the sync of roles that become suspended / reactivated.

Syxton commented 7 years ago

72

Syxton commented 7 years ago

@Hiroshi-p Here is the activation / deactivation event code

hohno-panopto commented 7 years ago

Panopto internal track number 42729