search

Panopto / Moodle-2.0-plugin-for-Panopto

Panopto's integration with the Moodle LMS.
http://www.panopto.com
GNU General Public License v3.0
18 stars 40 forks source link

Consolidate SoapClient derived classes #94

Closed woolardfa closed 7 years ago

woolardfa commented 7 years ago

Noticed only one SoapClient extended class needed, so consolidated the two.

Even if you choose to not use this commit, there is a typo on the soap_client_with_timeout constructor (one underscore instead of two) that keeps it from being called, thus defeating the timeout feature altogether.

jmalmsten-panopto commented 7 years ago

Hi,

We appreciate this extra work, and will look into this and see what we can use in an upcoming update. Unfortunately we are completely moving away from the ClientData api to the PublicAPI v4.x we use in our other LMS integrations, so most of these files will be going away very soon.

While performing this migration I'll investigate and address your concerns listed in #92 and #93, I will create internal work items for these, so just be on the look out for our next major release.

Thanks, Joe