PanosK92 / SpartanEngine

A game engine with an emphasis on real-time cutting-edge solutions
https://panoskarabelas.com
MIT License
2.24k stars 189 forks source link

imgui style update #159

Closed ege-del closed 1 month ago

ege-del commented 1 month ago

needs a little polish but i think its good time to get some feedback on the general idea and implementation

using static variables for now just to check things quickly, ideally most of the ImGui_Style.h code would be contained in its widget with theme editor window. but we would still need some static variables so each widget can refer to common colors for 'info' 'warning' 'error' etc col4

PanosK92 commented 1 month ago

I’ve had a look at your work, and I’m impressed! The theme is definitely a step up, and minimalism/simplicity is something I’m a big fan of. Feel free to add whatever static variables you need, keeping it simple is the way to go.

Proceed as you see fit, I think you’ve got this. Let me know when you want feedback or are ready to merge.

ege-del commented 1 month ago

ready to merge, let me know if you notice any problems

PanosK92 commented 1 month ago

You did a fantastic job, thank you.

PanosK92 commented 1 month ago

I reached out on Discord, please check.