search

PantelisGeorgiadis / dcmjs-dimse

DICOM DIMSE implementation for Node.js using the dcmjs library
MIT License
68 stars 13 forks source link

Pass SNICallback through to TLS options #46

Closed richard-viney closed 1 year ago

richard-viney commented 1 year ago

Hi Pantelis,

Could we add SNICallback to the list of allowed security options, or maybe just pass everything through and use the types from @types/node on that parameter?

Thanks!

PantelisGeorgiadis commented 1 year ago

Hello Richard! SNICallback was added in Network, Server and Client options. Now that I'm thinking of it, I believe that this is a server feature and, therefore, this was not necessary to be included in the Client, right? If that's the case, I'm going to remove it in the next release.

Please test and let me know if the type I added is OK.

richard-viney commented 1 year ago

Looks great, but yes it is only an option for servers I believe.

PantelisGeorgiadis commented 1 year ago

Thank you Richard! In the latest update, SNICallback was removed from the Client options.