search

PantelisGeorgiadis / dcmjs-dimse

DICOM DIMSE implementation for Node.js using the dcmjs library
MIT License
74 stars 14 forks source link

Allow TLS ciphers to be set #53

Closed richard-viney closed 1 year ago

richard-viney commented 1 year ago

Hi Pantelis,

Currently ciphers can't be passed through in the config when running a TLS server. Could this be added? It'd go alongside the existing settings such as minVersion and maxVersion.

Thanks!

PantelisGeorgiadis commented 1 year ago

Hi Richard! Is this a server-only security feature or it should be exposed for the client also?

richard-viney commented 1 year ago

This is valid to specify for both servers and clients that want to restrict their accepted ciphers to a specific set, e.g. those considered to be strongest.

PantelisGeorgiadis commented 1 year ago

Thank you Richard! Version 0.1.22 allows the ciphers security option to be passed.

PantelisGeorgiadis commented 1 year ago

Hello @richard-viney ! Closing the issue now. If you feel that we can do more on that, please reopen or create a new issue.