Pantelwar / matching-engine

Superfast Matching Engine written in golang
69 stars 21 forks source link

Is this it stable? #14

Open centny opened 3 years ago

centny commented 3 years ago
github-actions[bot] commented 3 years ago

Message that will be displayed on users' first issue

centny commented 3 years ago

the code is panic when parralel running in server.go

    var pairBook *engine.OrderBook
    if val, ok := e.book[req.GetPair()]; ok {
        pairBook = val
    } else {
        pairBook = engine.NewOrderBook()
        e.book[req.GetPair()] = pairBook
    }
roman-wb commented 3 years ago

@centny order matching for every one pair currency or stock share should running in one goroutine/thread

ianeinser commented 3 years ago

@centny order matching for every one pair currency or stock share should running in one goroutine/thread

Hi @roman-wb ,

can you be more specific? would you share the code?

regards

sudhanshu-pantelwar commented 3 years ago

@ianeinser : you can check the following link to test the engine: https://github.com/Pantelwar/matching-engine/issues/13#issuecomment-882188281

Also there are test files associated with each order type.

Will update the README soon.