search

PantherLAB / PantherDashboard

Panther Dashboard for DQMH is a tool designed to improve the Developer Experience when working with DQMH Framework.
https://pantherlab.github.io/PantherDashboard/
12 stars 4 forks source link

small bug in markdown snippets for vipm.io badge #23

Closed jimkring closed 2 years ago

jimkring commented 2 years ago

We fixed it in the markdown snippet generator so it doesn't add the badge.svg/ at the end of the link/urlk

enoearias commented 2 years ago

Hi @jimkring, thank you!

jimkring commented 2 years ago

You're welcome. I think you can just merge the pull request and it'll be fixed.

enoearias commented 2 years ago

Yes I forgot to merge, this is my second time doing Pull request, I think I'm enjoing this Open source thing, I was a little bit of afraid to show my work, because it contains evidence of all my mistakes, but with a switch of perspective it contains also all my solutions to some problems (sometimes created by myself haha), it is just a matter of perspective. Thank you for providing the infraestructure to share code.

jimkring commented 2 years ago

@enoearias: You're welcome. Enrique. I appreciate your openness to share your code with everyone and your willingness to try new ways of working -- open source is all about sharing our mistakes and learning from each other in the process. Plus, it takes a lot of courage to do that, so you're setting a great example for others!  For me, I',m happy that I was able to actually share a fix and make it easy for you, since the bug was actually was my fault in the first place.

I'll also mention that I've only recently (in the past 6 months or so) really started using GitHub Pull Requests in my development workflow and I REALLY like it (but at first it seemed very different and a little bit overwhelming because I didn't really understand all the features and conventions). There's a lot one can to with PRs like code reviews and a variety of project automation. We'll stick with it and work together to get better :)