Dismiss cards cause black screen on iOS13 and Xcode 11.2

PaoloCuscela / Cards

Awesome iOS 11 appstore cards in swift 5.

MIT License

4.2k stars 274 forks source link

Dismiss cards cause black screen on iOS13 and Xcode 11.2 #134

Closed Rida-ba closed 4 years ago

Rida-ba commented 4 years ago

First, I want to thank you for your work. It's awesome feature but I'm sorry to let you know that it's not working anymore on iOS13 and Xcode 11.2. Maybe I'm the only one but I prefer to tell you.

As we can see on this following screen :

I don't know if this is an animation issue but if you have a clue, I will be grateful.

Thanks in advance for your help.

Rida.

Rida-ba commented 4 years ago

Don't worry, I resolve this issue by myself. It's known problem in iOS 13 because Apple change their view presentation style. So starting from now we have to add this following line into Cards.swift :

detailVC.modalPresentationStyle = .fullScreen

Specially when you initialize DetailViewController in open func initialize().

I hope you can fix it with my advice in the next release.