PaoloCuscela / Cards

Awesome iOS 11 appstore cards in swift 5.
MIT License
4.2k stars 274 forks source link

TableView Issues #53

Closed asikand-view closed 6 years ago

asikand-view commented 6 years ago

I have cards working as TableViewCell's and they are working fine apart from two major issues.

1) When you dismiss the card, and it returns to its place in the TableView it is often misaligned or has adjusted its size strangely.

Notice the third cell misaligned

2) After opening and dismissing Cards in the TableView, eventually, the cards stop presenting the view controller content. Like this:

Working screen shot 2018-06-11 at 11 51 21 am Stops Presenting screen shot 2018-06-11 at 11 52 10 am

Varmoes commented 6 years ago

I've got the same two issues. On issue number 1, I found it's affected by scrolling (if you put your finger on a card and start scrolling, it seems to interpret it as being long pressed).

asikand-view commented 6 years ago

I think the disappearing content has to do with the View becoming stale as part of a stack or there being some kind of a memory issue, I'm no pro but I think it could relate to #43

asikand-view commented 6 years ago

@Varmoes @PaoloCuscela I've solved Issue Number 1 with this fix in Card.swift:

private func pushBackAnimated() {
    //UIView.animate(withDuration: 0.2, animations: { self.transform = CGAffineTransform(scaleX: 0.95, y: 0.95) })
}
PaoloCuscela commented 6 years ago

Fixed each of them. Good work 👍

skeetyeet commented 6 years ago

Hi I am still getting the 2nd issue. How was it solved in this case? Thanks in advance.

(After I open/close 5 different cards, the issue occurs)

Edit: Nevermind. Found that the detail controllers view alpha was staying at 0 for some reason.