There should be something wrong with XScreen and YScreen

PaoloCuscela / Cards

Awesome iOS 11 appstore cards in swift 5.

MIT License

4.2k stars 274 forks source link

There should be something wrong with XScreen and YScreen #91

Closed akring closed 5 years ago

akring commented 5 years ago

static public func XScreen(_ percentage: CGFloat) -> CGFloat {

        return percentage * UIScreen.main.bounds.height / 100

}

static public func YScreen(_ percentage: CGFloat) -> CGFloat {

        return percentage * UIScreen.main.bounds.width / 100

}

I think we should swap width and height ?😂

PaoloCuscela commented 5 years ago

Yep you're right :P Fixing on this soon