PapaJoesSoup / BDArmory

Gun turrets and other weapon systems for KSP
113 stars 57 forks source link

Guard mode in Space #273

Open gbem1113 opened 7 years ago

gbem1113 commented 7 years ago
ISSUE TYPE
KSP and BDA Version

1.3

0.3.0.0

OS / ENVIRONMENT

windows 8.1

SUMMARY

guard mode does not work in space

cannons bugged in space

STEPS TO REPRODUCE
Log Files

no log files as crash is absent

DoctorDavinci commented 7 years ago

BDAc is designed for atmospheric combat, not space combat

gbem1113 commented 7 years ago

Well BDAc used to work perfectly in space during its earlier incarnations. Used to have wonderful space battles akin to BSG starwars or star trek. Sadly same cannot be said for the newer versions.

However if not a bug then how about a feature? it would be great to see space combat return to BDAc

PapaJoesSoup commented 7 years ago

Can you name the version or versions that apply? and what version of KSP they worked on? Since there is history on development here and in Baha's original Repo, it may be possible to determine what (if anything) is broke... But to do so you will need to provide specifics on steps to reproduce the "error" and describe it in sufficient detail that we can determine in code what is going on.

jrodrigv commented 7 years ago

There is already a Feature Request related #37

PapaJoesSoup commented 7 years ago

Ok, then I suggest gbem1113, that all information relating to this issue be posted there so that the feature request can be characterized. We will need more detail than simply it is broke. Explain what the previous behavior was (in detail) and explain what the current behavior is (in detail). Steps to reproduce are always helpful, as it aids us in locating where in code things may be different.

Taking these steps will aid us in determining the level of effort and whether or not to move it up the priority list. As you can see, there is nothing there right now.

gbem1113 commented 7 years ago

My last build featuring "ok" space combat dynamics was using BDarmory was v0.9.9. i am unsure which version was the latest for it to work on. In days of old guard mode simply engaged and shot the target as if it were in atmosphere

to reproduce it simply launch the craft into space and activate guard mode against any space based target. It still fires normally against ground based targets when physics range extender is used which leads me to believe it has something to do with the engagement options not having a "space" condition for the vessel

here are some screenies one with engagement all options on 20170813201215_1 one with engagement options disabled 20170813201400_1

both tests still returned negative The same craft engaged targets on the ground or on atmo without issue. the vessel simply refuses to engage any spacecraft

gbem1113 commented 7 years ago

The cannon problem has similar steps. Launch an armored vehicle into space and contrast it to one on the ground then shoot at it with a cannon and you will find much higher impulse and heat transfer done on the ground based target in contrast to the space based target.

Last working version of BDA i had was v0.9.9 but i shall test out which iteration last contains the working system.

PapaJoesSoup commented 7 years ago

Thanks! That info will be helpful.

ghost commented 7 years ago

Quick code review: yes, no engage options matches a vessel orbiting.

Choices:

@team: preferences?