search

PapaJoesSoup / ShipManifest

Kerbal Space Program Addon. Manages Crew, Science, & Resources on a given vessel.
Other
32 stars 25 forks source link

KIS Inventories are not swapped when swapping crewmembers #21

Closed PapaJoesSoup closed 3 years ago

PapaJoesSoup commented 8 years ago

when swapping crewmembers (target part is full), inventories are not alsow swapped. In addition, when moving a crewmember to another seat within the same part, the inventory also does not move.

Reported by by: jofwu

Forum Link: http://forum.kerbalspaceprogram.com/index.php?/topic/56643-105-ship-manifest-crew-science-resources-v-5010-14-mar-16/&do=findComment&comment=2435359

mwerle commented 7 years ago

Additionally, anytime when moving a crew members to a new part, the KIS inventory is not moved with the crew member. (KSP1.3.1.1, SM 5.2.0.0, various other mods; removing SM and trying again resulted in the Kerbal moving along with their KIS inventories)

Attached my modlist. Most are probably not required to reproduce; but you will need Nehemiah-Inc complete, the Corvus pod, and of course SM and their dependencies to reproduce. The vessel is Orbit 2.3, and moving Jebedia from the Mk1 pod leaves the inventory in the Mk1 pod, after Jeb has moved.

installed-default.zip persistent (2017_10_18_18_16_21).zip

EDIT: In fact it's trivial to reproduce with just KIS and SM installed, just build a ship which has multiple crew compartments, add some KIS items to a seat, then move the Kerbal. The KIS inventory stays with the original seat after the Kerbal has moved. If you then EVA the Kerbal, the inventory is lost.

mwerle commented 4 years ago

I think I fixed this, it was probably broken in 7a45d2060cd8bc7efdca833e0d807c743bd5cd8d when the Source- and TargetAction callbacks were no longer being set up.