New terminate - Githubissues

PaperCutSoftware / silver

SILVER - A cross-platform service/daemon wrapper with in-build auto-update, crash resilience and more.

MIT License

54 stars 13 forks source link

New terminate #16

Closed Dan-Dongcheol-Lee closed 7 years ago

Dan-Dongcheol-Lee commented 7 years ago

Lets merge the branch to master after quick code review. Feel free to cancel the pull request if we need to do more things on the branch.

LarsOL commented 7 years ago

Considering this has essentially been master since the middle of last year. We really should merge this @tinhtruong @codedance. I think @Dan-Dongcheol-Lee @hiroxy and I already approve.

Anything that is stopping this?

hiroxy commented 7 years ago

Have fixed the conflicts

Dan-Dongcheol-Lee commented 7 years ago

Sorry guys, realised that this pull request excludes my changes which I had reverted when I was closing this. didn't see the logs of reverted messages though Therefore, it would be all right to be merged once approved.

hiroxy commented 7 years ago

Test_Execute_ShouldExecuteNormalCommandProperly in the cmdutil package and Test_ProcessKillGracefully_GUIProgram in the osutils package fail because OS specific absolute paths are used
Test_ExecuteRandomStartupDelayTask and Test_ExecuteTask_GracefulShutDown_OK in svcutil pacakge are flaky test cases

hiroxy commented 7 years ago

I've fixed the issues I commented.

Dan-Dongcheol-Lee commented 7 years ago

thanks Hiroshi!