PaperMC / Folia

Fork of Paper which adds regionised multithreading to the dedicated server.
GNU General Public License v3.0
3.52k stars 442 forks source link

Thread Region Scheduler Thread #2 failed main thread check: Cannot add entity off-main thread #167

Closed roggy666 closed 10 months ago

roggy666 commented 10 months ago

Stack trace

https://paste.gg/p/anonymous/270e834a3a084d999399605cb7a1dc06

Plugin and Datapack List

[21:10:55 INFO]: Paper Plugins: [21:10:55 INFO]: - eco, EcoEnchants, HuskHomes, Talismans [21:10:55 INFO]: Bukkit Plugins: [21:10:55 INFO]: - AlchemicalArrows, Alchemy, AntiShulkPotion, Astro, AutoMineReset, BetterRTP, BlueSlimeCore, BottledExp, Buyers, ChatEx [21:10:55 INFO]: Chunky, ChunkyBorder, CmdBlock, CMILib, CombatLogX, CommandPanels, CooldownsX, CrossplatCommands, CrossplatHolders, DecentHolograms [21:10:55 INFO]: DeluxeTags, ElytraFly, Essentials, FancyNpcs, FireworkPvP, floodgate, FloodgateCP, FloodgateCPvTwo, FlyJack, FoliaUtils [21:10:55 INFO]: GlitchBedrockEnchant, GlitchCasts, GlitchChests, GlitchItems, GlitchMobs, GraceCases, GSit, libreforge, LuckPerms, MiniCMI [21:10:55 INFO]: OffHand, PlaceholderAPI, PlayerKits, PlugManX, PotionLake, ProtectionStones, ProtocolLib, PSAddon, *RedisEconomy, SkinsRestorer [21:10:55 INFO]: spark, TAB, TabCompleter, TimeRewards, TokenManager, Triton, UltraPickaxe, Vault, ViaBackwards, ViaVersion [21:10:55 INFO]: WorldEdit, WorldGuard, WorldGuardExtraFlags, zAuctionHouseRedis, zAuctionHouseV3, zSchedulers

Actions to reproduce (if known)

No response

Folia version

[21:13:32 INFO]: This server is running Folia version git-Folia-"757cb09" (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 757cb09 on dev/1.20.2)

Other

No response

### Tasks
Nicolol1234 commented 10 months ago

You shouldn't use folia, like eco isn't compatible with folia, and probably many of the other that ur using

Nicolol1234 commented 10 months ago

And plugmanX is 💀

roggy666 commented 10 months ago

You shouldn't use folia, like eco isn't compatible with folia, and probably many of the other that ur using

I have rewritten versions for folia

Spottedleaf commented 10 months ago

This will happen when a plugin teleports a player during the move event handling. I could add a check for when this happens, but it's improper to invoke teleportations during these events as it's possible that other plugins listening will not be aware of the teleport. It would be inappropriate to try and support such behavior.

The event itself supports setting the destination location as well as cancellation (for about as long as the event has existed!), so there is no reason for plugins to be performing this behavior.

I also notice that custom worlds are loaded, which isn't exactly possible on standard Folia to my knowledge.