search

PaperMC / Paper

The most widely used, high performance Minecraft server that aims to fix gameplay and mechanics inconsistencies
https://papermc.io/
Other
9.74k stars 2.27k forks source link

EntityDamageByEntity event fires a PlayerInteractEvent if attacking outside of vanilla interaction range. #10857

Closed anth64 closed 1 month ago

anth64 commented 4 months ago

Expected behavior

PlayerInteractEvent should not fire after EntityDamageByEntityEvent.

Observed/Actual behavior

PlayerInteractEvent fires after EntityDamageByEntityEvent when attacking outside of vanilla attack range.

Steps/models to reproduce

Just give an item an interact reach modifier, attack an entity outside of the vanilla minecraft attack reach and the PlayerInteractEvent will fire.

Plugin and Datapack List

None.

Paper version

This server is running Paper version 1.20.6-137-master@bd5867a (2024-06-04T21:04:28Z) (Implementing API version 1.20.6-R0.1-SNAPSHOT)

Other

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/nms-patches/net/minecraft/server/network/PlayerConnection.patch#722 https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/nms-patches/net/minecraft/server/network/PlayerConnection.patch#1126