search

PaperMC / Paper

The most widely used, high performance Minecraft server that aims to fix gameplay and mechanics inconsistencies
https://papermc.io/
Other
9.37k stars 2.19k forks source link

1.20.5 particle builder is broken #10872

Open JHarris12345 opened 3 weeks ago

JHarris12345 commented 3 weeks ago

Expected behavior

I shouldn't receive an error to add the Color data to an ENTITY_EFFECT particle

Observed/Actual behavior

It throws this error [21:55:43 WARN]: [ICClass] Task #30790 for ICClass v1.0 generated an exception java.lang.IllegalArgumentException: missing required data class org.bukkit.Color

Steps/models to reproduce

I spawn the particle with

p.world.spawnParticle(Particle.ENTITY_EFFECT) (shortened code but you get the point) It gives me the error above.

However, if I then use the particle builder to add a color, I get the new error [21:56:49 WARN]: [ICClass] Task #30817 for ICClass v1.0 generated an exception java.lang.IllegalStateException: Color may only be set on particle DUST.

Plugin and Datapack List

[22:01:04 INFO]: Server Plugins (79): [22:01:04 INFO]: Bukkit Plugins: [22:01:04 INFO]: - AdvancedAchievements, AdvancedArmorStands, AdvancedEnchantments, Brewery, BuycraftX, ChestShop, ChestShop-LegacyIds, Chunky, Citizens, ClearLag [22:01:04 INFO]: Commander, CoreProtect, CrazyAuctions, DeluxeMenus, DespawnSpy, DetrimUtils, EnchantGui, Essentials, EssentialsAntiBuild, EssentialsGeoIP [22:01:04 INFO]: EssentialsProtect, EssentialsSpawn, ExploitFixer, FarmLimiter, FeatherBoard, floodgate, GPFlags, GriefPrevention, GSit, HamsterAPI [22:01:04 INFO]: HolographicDisplays, ICClass, IllegalStack, InsanityChat, InsanityCore, InsanityCrates, InsanityDuels, InsanityMinions, InsanityModeration, InsanityShops [22:01:04 INFO]: InsanityStacker, InsanityWarps, LibsDisguises, LuckPerms, mcMMO, MineableSpawners, MorphRedeem, Multiverse-Core, MyCommand, MyCommand [22:01:04 INFO]: OpenInv, PlaceholderAPI, PlayerParticles, PlayerVaults, PlotSquared, PlugManX, ProtocolLib, PyroFishingPro, PyroLib, RedstoneClockDetector [22:01:04 INFO]: RestrictedCreative, Sentry, SeparateInventories, spark, StableMaster, StellarTags, TAB, TradeSystem, Vault, ViaBackwards [22:01:04 INFO]: ViaRewind, ViaVersion, Votifier, VotingPlugin, Vulcan, WildTools, WorldEdit, WorldGuard, WorldGuardExtraFlags

Paper version

This server is running Paper version 1.20.6-138-master@906df69 (2024-06-10T06:32:15Z) (Implementing API version 1.20.6-R0.1-SNAPSHOT) You are running the latest version Previous version: git-Paper-318 (MC: 1.20.2)

Other

No response

lynxplay commented 3 weeks ago

Accepted, particle builder needs to be expanded to accept colours for ENTITY_EFFECT, preferably by dynamically checking the particles accepted data type.