search

PaperMC / Paper

The most widely used, high performance Minecraft server that aims to fix gameplay and mechanics inconsistencies
https://papermc.io/
Other
9.37k stars 2.19k forks source link

Error upgrading world (1.20.4 -> 1.20.6) #10894

Closed andrewkm closed 2 weeks ago

andrewkm commented 2 weeks ago

Stack trace

[22:33:05] [Server thread/INFO]: 38% completed (1414741 / 3707558 chunks)...
[22:33:06] [Server thread/INFO]: 38% completed (1415465 / 3707558 chunks)...
[22:33:07] [Server thread/INFO]: 38% completed (1416089 / 3707558 chunks)...
[22:33:08] [Server thread/INFO]: 38% completed (1416662 / 3707558 chunks)...
[22:33:08] [pool-68-thread-1/ERROR]: Error upgrading world
net.minecraft.ReportedException: Updated chunk
    at net.minecraft.world.level.chunk.storage.ChunkStorage.upgradeChunkTag(ChunkStorage.java:141) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at net.minecraft.util.worldupdate.WorldUpgrader$ChunkUpgrader.tryProcessOnePosition(WorldUpgrader.java:203) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at net.minecraft.util.worldupdate.WorldUpgrader$ChunkUpgrader.tryProcessOnePosition(WorldUpgrader.java:191) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at net.minecraft.util.worldupdate.WorldUpgrader$AbstractUpgrader.processOnePosition(WorldUpgrader.java:470) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at net.minecraft.util.worldupdate.WorldUpgrader$AbstractUpgrader.upgrade(WorldUpgrader.java:340) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at net.minecraft.util.worldupdate.WorldUpgrader.work(WorldUpgrader.java:118) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at java.base/java.lang.Thread.run(Thread.java:1570) ~[?:?]
Caused by: java.lang.NullPointerException: Cannot invoke "ca.spottedleaf.dataconverter.types.ListType.size()" because "armor" is null
    at ca.spottedleaf.dataconverter.minecraft.versions.V3808$1BodyArmorConverter.convert(V3808.java:47) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.versions.V3808$1BodyArmorConverter.convert(V3808.java:17) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.datatypes.IDDataType$1.convert(IDDataType.java:30) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.datatypes.IDDataType$1.convert(IDDataType.java:24) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.datatypes.IDDataType.convert(IDDataType.java:97) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.versions.V704.lambda$register$2(V704.java:386) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.datatypes.IDDataType.convert(IDDataType.java:133) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.datatypes.IDDataType.convert(IDDataType.java:15) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.walkers.generic.DataWalkerListPaths.walk(DataWalkerListPaths.java:29) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.walkers.generic.DataWalkerListPaths.walk(DataWalkerListPaths.java:8) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.datatypes.IDDataType.convert(IDDataType.java:145) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.walkers.generic.WalkerUtils.convertList(WalkerUtils.java:35) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.versions.V2843.lambda$register$0(V2843.java:72) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.datatypes.MCDataType.convert(MCDataType.java:111) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.datatypes.MCDataType.convert(MCDataType.java:13) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.MCDataConverter.convert(MCDataConverter.java:56) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at ca.spottedleaf.dataconverter.minecraft.MCDataConverter.convertTag(MCDataConverter.java:30) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    at net.minecraft.world.level.chunk.storage.ChunkStorage.upgradeChunkTag(ChunkStorage.java:123) ~[paper-1.20.6.jar:1.20.6-145-fe7043e]
    ... 6 more

Plugin and Datapack List

On request via Discord.

Actions to reproduce (if known)

Use --forceUpgrade when upgrading from Paper 1.20.4 (Build 497) to Paper 1.20.6 (Build 145)

Paper version

Paper version 1.20.6-145-ver/1.20.6@fe7043e

Other

forceUpgrade reached 38% and then encountered above stack trace. The upgrade stopped, and the server continued to load. The world did not continue to upgrade. Dozens of other worlds upgraded just fine.

I did notice this a few lines below the stack trace, unsure if relevant: https://pastebin.com/raw/qUwSBwig

MiniDigger commented 2 weeks ago

I guess https://github.com/PaperMC/Paper/commit/f873bcee24264ea91a3350af871222b09c4ee228 needs to be backported