search

PaperMC / Paper

The most widely used, high performance Minecraft server that aims to fix gameplay and mechanics inconsistencies
https://papermc.io/
Other
9.91k stars 2.29k forks source link

Reloading the servers list during the startup cause errors #1473

Closed iGabyTM closed 6 years ago

iGabyTM commented 6 years ago

Link/paste of stack trace

https://paste.helpch.at/idafitomap.md

Plugin list:

AgarthaLib, Carz, Citizens, CitizensCMD, DreamFish, Essentials, EssentialsSpawn, FastAsyncWorldEdit, HolographicDisplays, HolographicExtension, LuckPerms, NametagEdit, PlaceholderAPI, PlugMan, ProtocolLib, QuickBoard, TitleManager, Vault, ViaBackwards, ViaVersion, WG-GUI, WorldEdit, WorldGuard, WorldGuardExtraFlags

Actions to reproduce (if known):

Servers list refresh during the startup

Paper build number:

1562

BillyGalbreath commented 6 years ago

@Minecrell I was told to ping you for this.

My diagnosis is a simple race condition. During startup there is a short period where the server is responding to pings (creating the server list ping event) before the player sample is actually populated, creating the NPE.

zachbr commented 6 years ago

Thanks for letting us know. 1.13.1 Builds 289+

zachbr commented 6 years ago

1.12.2 builds 1564+