search

PaperMC / Paper

The most widely used, high performance Minecraft server that aims to fix gameplay and mechanics inconsistencies
https://papermc.io/
Other
9.89k stars 2.29k forks source link

When console is loading some deprecated warns from plugins are joining onto un-related plugin loading posts #2054

Closed axemwa closed 5 years ago

axemwa commented 5 years ago

What behaviour is expected:

For deprecated WARNs to be on appropriate lines/posts and to not join onto other plugins Loading/Loaded statements in console In this cause the CCTV deprecated method WARN is appearing inside the TokenEnchant loading statement and there needs to be a space/return/enter between the 2 lines/plugin statements

What behaviour is observed:

When console is loading, some deprecated warns from other plugins are appearing in un-related plugin loading posts

Steps/models to reproduce:

Find a plugin that uses deprecated methods Notice that deprecated methods post gets attached to a loading post/statement from another unrelated plugin

Plugin list:

ActionHealth, AdvancedAchievements, AdvancedPortals, AdvancedTeleport, AgarthaLib, AntiDrop, AppleTreeReloaded, AquaticsPlus, ArmedArmorStands, ArmorStandCmd, ArmorStandTools, AsyncWorldEdit, AuthMe, AutomaticInventory, AutoTorch, BetterDrops, BetterExplosions, BKCommonLib, BlockElytraArrowBoost, BlockStatus, BookExploitFix, Bookshelves, BotMaker, BottleRecycling, Broadcaster, Builder, Cannons, CCTV, ChatControl, ChatInjector, CheckNameHistory, Citizens, CitizensBooks, CitizensCMD, CitizensText, ClearLag, ClickSort, ColorAnvil, ColorCodes, CommandAPI, CommandPrompter, ConsoleSpamFix, CraftBook, CrateReloaded, CropChecker, CS-CoreLib, CustomCommands, CustomEnderChest, DeathEffects, DeluxeMenus, Denizen, DiceFurniture, DiscoFloor, DiscordSRV, DontPutItHere, DragonEggRespawn, DropNames, dtlTraders, DurabilityBar, DynamicSigns, EditableSign, eGlow, ElytraLanding, EnchantGUI, Essentials, EssentialsGeoIP, ExtraContexts, eZProtector, F3Name, FarmLimiter, FirstJoinPlus, ForceResourcepacks, FurnitureLib, FurnitureLib-GUI, GCore, GiveAll, GlowAPI, GlowFeller, HeadDatabase, HolographicDisplays, HolographicExtension, HorseTpWithMe, HotbarSounds, ID-Library, iDisguise, iDisguiseAdditions, iDisguiseWG, InfoBook, InventoryFullPlus, InventoryRollback, InvisibilityPlus, JukeBox, JupiterCore, KeepChunks, KeyCommandBind, LastHolo, LeadTheWay, LibsDisguises, LightAPI, LightCleaner, Lightnings, LMGTFY, LuckPerms, LuckPerms-GUI, LuckPermsCompat, LuckPermsMVdWHook, LuckyBlocksPro, MaintenanceSpigot, Maplands, MassiveCore, Missing_Recipes, MoneyHunters, MoonGenerator, MorphTool, MultiInv, Multiverse-Core, Multiverse-NetherPortals, Multiverse-Portals, Multiverse-SignPortals, MVdWPlaceholderAPI, MVdWUpdater, NewAmazingLuckyBlocks, NewGods, NoBlackSky, NoStrip, NoteBlockAPI, OfflineTeleporter, OpenInv, OreReplacerPlugin, OwnGarden, PacketListenerApi, PAPISign, ParadiseLand, PEC, PersonalInfo, PetMaster, PhantomSpawnControl, PickupArrows, PingAlert, PingFix, PlaceholderAPI, PlayerParticles, PlayerRider, PluginManagerReloaded, ProtectionLib, ProtocolLib, ProtocolSupportPotions, PublicCrafters, Purgatory, RainbowBlocks, RandomTeleport, RealDualWield, RealisticLiquid, Redye, RFChairs, Ridables, RPGInventory, RuggedTrails, Seashells, SelectionVisualizer, Sentinel, SerialKey, ServerAge, ServerPropertiesIGE, Shopkeepers, ShowItem, ShulkerBoxPackPacks, SilkSpawners, SimpleCompass, SimpleNightVision, SimpleSit, SmokingPipes, SmoothSleep, spark, StopTramplingMyCrops, SuperLuckyBlock, SuperTrails, TabList, TallNether, TintHealth, TitleManager, TNTChestBlock, TokenEnchant, ToolStats, Towny, TownyChat, TownyGUI, TownyNameUpdater, TownyTitle, TradeMe, TwexMotes, UltimateDrugs, UltimateTrash, UsersReport, Vault, VisualFixer, VoidGenerator, Votifier, VotingPlugin, WDLCompanion, WG-GUI, WingCommander, WishArmour*, WorldBorder, WorldChangeScreenRemover, WorldEdit, WorldGuard, WorldGuardExtraFlags

Paper build number:

Paper version git-Paper-626 (MC: 1.13.2) (Implementing API version 1.13.2-R0.1-SNAPSHOT)

Anything else:

A picture of the posts/statements joining image

mikroskeem commented 5 years ago

Seems to be up to plugin authors to use correct ways for logging, seems like TokenEnchant is using System.out.print (instead of proper logger or atleast System.out.println...).

electronicboy commented 5 years ago

Premium plugin, so nobody here really has a way to investigate if they're doing something weird, but, they're clearly not using the logger properly (if at all), all log messages should appear on their own line, just when stuff is printing outside of the logger directly to the terminal, stuff basically ends up where it ends up

axemwa commented 5 years ago

Ok thanx guyz I'll report it to the author :)