PaperMC / Paper

The most widely used, high performance Minecraft server that aims to fix gameplay and mechanics inconsistencies
https://papermc.io/
Other
9.89k stars 2.29k forks source link

Restart script "start.bat" no longer working in windows? #2402

Closed axemwa closed 5 years ago

axemwa commented 5 years ago

What behaviour is expected:

When using restart, console should automatically load up again

What behaviour is observed:

Console/server doesn't restart when attempting to use restart command after the server starts

Steps/models to reproduce:

use "start.bat" as the restart script, start server, once loaded type restart

Plugin list:

ActionAnnouncer, ActionHealth, AdvancedAchievements, AdvancedPortals, AdvancedTeleport, AnimatedFrames, AquaticsPlus, ArmedArmorStands, ArmorStandCmd, ArmorStandTools, AsyncWorldEdit, AuthMe, AutomaticInventory, AutoTorch, AutumnLeaves, BestViewDistance, BetterBeacons, BetterDrops, BetterExplosions, BKCommonLib, BlockElytraArrowBoost, BlockStatus, BookExploitFix, Bookshelves, BottleRecycling, Broadcaster, Builder, Cannons, CCTV, ChatControl, ChatInjector, CheckDeath, CheckNameHistory, Citizens, CitizensCMD, CitizensText, ClearLag, ClickSort, ClientStats, ColorAnvil, ColorCodes, CommandAPI, CommandPrompter, CommandsXL, ConsoleSpamFix, CrackShot, CrateReloaded, CrispyDisguise, CropChecker, CS-CoreLib, CustomCommands, DeathEffects, DeluxeMenus, Denizen, DiceFurniture, DiscoFloor, DiscordSRV, DontPutItHere, DragonEggRespawn, DropNames, dtlTraders, DurabilityBar, DynamicSigns, EditableSign, eGlow, ElytraLanding, EnchantGUI, Essentials, EssentialsGeoIP, ExtraContexts, eZProtector, F3Name, FarmLimiter, FirstJoinPlus, ForceResourcepacks, FurnitureLib, FurnitureLib-GUI, GCore, GiveAll, GlowAPI, GlowFeller, gravy, HeadDatabase, Holograms, HolographicDisplays, HolographicDisplaysExtension, HolographicExtension, HolographicMenus, HorseTpWithMe, HotbarSounds, ID-Library, InfoBook, InventoryFullPlus, InventoryRollback, InvisibilityPlus, JukeBox, JupiterCore, KeyCommandBind, LeadTheWay, LibsDisguises, LightAPI, LightCleaner, Lightnings, LMGTFY, LuckPerms, LuckPermsCompat, LuckPermsMVdWHook, LuckyBlocksPro, MaintenanceAddon, MaintenanceSpigot, Maplands, MapManager, MassiveCore, Missing_Recipes, MoneyHunters, MorphTool, MultiInv, Multiverse-Core, Multiverse-NetherPortals, Multiverse-Portals, Multiverse-SignPortals, MVdWPlaceholderAPI, MVdWUpdater, NoStrip, NoteBlockAPI, NPC_Destinations, OfflineTeleporter, OpenInv, OreReplacerPlugin, OwnGarden, PacketListenerApi, PAPISign, ParadiseLand, PEC, PersonalInfo, PetMaster, PhantomSpawnControl, PickupArrows, PingAlert, PingFix, PlaceholderAPI, PlayerParticles, PlayerRider, PluginConstructorAPI, PluginManagerReloaded, ProtectionLib, ProtocolLib, ProtocolSupport, ProtocolSupportLegacyChest, ProtocolSupportPotions, ProtocolSupportStuff, PublicCrafters, PulseHealth, Purgatory, QuickClose, RainbowBlocks, RandomTeleport, RealDualWield, RealisticLiquid, Redye, RegionUnstuck, RFChairs, Ridables, RPGInventory, RuggedTrails, SeaShells, SelectionVisualizer, Sentinel, SerialKey, ServerAge, ServerPropertiesIGE, Shopkeepers, ShowItem, ShulkerBoxBackPacks, SilkSpawners, SimpleCompass, SimpleNightVision, SimpleSit, SkipNight, SmokingPipes, SmoothSleep, spark, SpigotLib, StopTramplingMyCrops, SuperTrails, SuperVanish, TabList, TallNether, TintHealth, TitleAPI, TitleManager, TNTChestBlock, TokenEnchant, ToolStats, Towny, TownyChat, TownyGUI, TownyNameUpdater, TradeMe, TwexMotes, UltimateDrugs, UsersReport, Vault, ViaVersion, VisualFixer, VoidGenerator, Votifier, VotingPlugin, WG-GUI, WingCommander, WishArmour, WorldBorder, WorldChangeScreenRemover, WorldEdit, WorldGuard, WorldGuardExtraFlags

Paper build number:

This server is running Paper version git-Paper-641 (MC: 1.13.2) (Implementing API version 1.13.2-R0.1-SNAPSHOT)

MiniDigger commented 5 years ago

Can you attach a log of a restart and the content of your start.bat?

axemwa commented 5 years ago

Wow it actually started working again (sometimes it works sometimes it doesn't, it does this at times), for restart-script I have "start.bat" set which is normal for windows right? I'll send the restart log next time it doesn't restart

electronicboy commented 5 years ago

restart works fine, the issue is the concept is basically broken You're attempting to start a server process before the old one has ended, this can often lead to a variety of race conditions such as having the right amount of free memory when java needs it and if the network port is available; Heavily recommend using a startup script that's designed to auto restart vs relying on the mechanism built into spigot

axemwa commented 5 years ago

k thanx for explaining that I'm not sure how to make a script that autorestarts the server, guess I got some googling to do. Yeah it may have been a memory problem ports are working fine plus I using Ethernet cable, restart is working normal again it seems. Almost seems like re-entering the start.bat script and starting the server again fixed it but then again more than likely a coincidense