search

PaperMC / Paper

The most widely used, high performance Minecraft server that aims to fix gameplay and mechanics inconsistencies
https://papermc.io/
Other
9.73k stars 2.27k forks source link

Make 'enable-treasure-maps: false' disable more than just cartographers #3480

Closed ghost closed 4 years ago

ghost commented 4 years ago

Is your feature request related to a problem? Please describe. Yes, shipwreck maps are causing huge amounts of server lag, 20+ second lagspikes

Describe the solution you'd like If enable-treasure-maps is false in the config, do not have treasure maps in shipwreck chests

Describe alternatives you've considered datapack to remove treasure maps?

Additional context Image of lagspikes: (97% server tick) https://imgur.com/a/5LCweKT

JRoy commented 4 years ago

care to post the actual spark and timings not a screenshot

Phoenix616 commented 4 years ago

Actual profile report was shared in the paper discord before: https://spark.lucko.me/#2O1zfw0paM

ghost commented 4 years ago

Update: removing treasure maps from loottables using a datapack did not fix the issue, server is still experiencing huge lagspikes for the same reason.

aikar commented 4 years ago

I'm going to leave this open as the feature is valid ,the config SHOULD work for all, however this is less needed now as I just pushed fix for making the treasure maps not load chunks and instead compute biome by seed.

Techcable commented 4 years ago

This should be much less of an issue now that Aikar changed the code to quickly compute biomes instead of loading chunks.

However, this is also related to #3536. When chunks are loading async, there could be lock contention with the biome computations. Working on a fix for that :) After that, I should be able to expand the config to work for shipwreck chests.