Possible Lighting Issue After Build 83

ghost commented 3 years ago

Timings or Profile link

https://timings.aikar.co/?id=1eeb46ec9436401592f5c757455459eb

Description of issue

We're having some performance issues after updating to 1.17, even after the latest patch from build 79.

Neither Spark or Timings points to a direct plugin culprit, and Spark is showing significant usage with the net.minecraft.server.level.ChunkMapDistance.a() method. We usually are able to identify whether a plugin is the cause or not, but we cannot find any relationship to a single plugin.

Our next guess was that maybe multiple MySQL connections to the same machine would cause issues for the writing speed of our NVMe drive but after trying to gut the high usage plugins, it made no difference.

Maybe there is something weird going on where there is in fact a plugin causing this issue but we can't see it using Timings or Spark?

Plugin list

Plugins (96): AdvancedEnchantments, AdvancedPortals, AttributeHider, BattlePass, Boosters, BuycraftX, ChatManager, Citizens, ClearLag, CombatLogX, CommandPanels, CoreProtect, CrazyAuctions, CustomCrates, CustomItems, CustomMessageCommands, CustomVillagerDrops, DeluxeCoinflip, DeluxeTags, DiscordSRV, EasyBackup, EasyBackupCore, EntityDetection, Essentials, EssentialsSpawn, ExploitFixer, ezBroadcast, FastLeafDecay, FindItemQS, floodgate, Geyser-Spigot, GSit, HamsterAPI, HolographicDisplays, Interactables, InventoryLogger, ItemBridge, JoinCommands, KeyShards, LootChest, LuckPerms, MCJellyLegs, MobCoinsCore, MobCoinsShop, Multiverse-Core, MVdWPlaceholderAPI, MyCommand, MysqlPlayerDataBridge, NerfPhantoms, OpenInv, PetFixes, PlaceholderAPI, Plan, PlayerParticles, PlugMan, ProtocolLib, Quests, QuestsGUI, QuickShop, RandomHandler, RandomRankUpgrades, RedstoneClockDetector, RemoveWanders, RoseStacker, RSBOmniBlock, RSBPaintBrushes, RSBPickUp, RSBSpawnDragon, RSBSpawnerMatrices, RSDeaths, RSRename, Sentinel, ServerListPlus, ShootingShards, ShopGUIPlus, ShowItem, ShulkerPacks, SpaceSellWands, spark, SuperiorSkyblock2, TAB-BukkitBridge, TradeSystem, TrashBin, UltimateAutoRestart, Vault, ViaBackwards, ViaRewind, ViaVersion, VoidSpawn, VotingPlugin, Vulcan, WallHacks*, WarpSystem, WorldEdit, WorldGuard, WorldGuardExtraFlags

Server config files

https://paste.gg/p/anonymous/4c94759a4a88496bb6e3a5d2b89ca4b3

Paper version

Checking version, please wait... This server is running Paper version git-Paper-90 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: bb44da8) You are running the latest version Previous version: git-Paper-83 (MC: 1.17.1)

Agreements

[x] I am running the latest version of Paper available from https://papermc.io/downloads.
[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] My version of Minecraft is supported by Paper.

Other

No response

ghost commented 3 years ago

Just updated to build 90 and the issue persists.

electronicboy commented 3 years ago

The server not performing as well in some aspects is already known and already reported across various issues, closing as we don't need another issue for this

ghost commented 3 years ago

It's performing much worse than just in a few aspects. Our TPS averages below 10 with only 20ish players online. I wasn't able to find other posts related to this issue in both the closed and opened tickets. Would you mind sending the link to it?

Thanks for the response.

Kamology commented 3 years ago

The server not performing as well in some aspects is already known and already reported across various issues, closing as we don't need another issue for this

I'd also super appreciate a reference to said issues to ensure it's being tracked, couldn't find any. If this is at all widespread and not just a result of something we've done wrong, it's perhaps the biggest issue I've ever seen with a server software or even just the vanilla game if that's the root cause. The server is quite literally unplayable due to this. Gonna try reverting back to Spigot in the meantime to see if that helps, had no luck with Papers forks.

electronicboy commented 3 years ago

https://github.com/PaperMC/Paper/issues/5980 for ex, there are a few bug reports of all the same nature which need clearing up but brain too spinny, we have a general idea of what's going on but needs a deep dive into it

PaperMC / Paper