Chests with treasure map crashing server

no10884 commented 1 year ago

Stack trace

paste your stack trace or a paste.gg link here!

https://paste.gg/p/anonymous/72bf51e0f6c2488f914de4f45d382897

Plugin and Datapack List

There are 2 data pack(s) enabled: [vanilla (built-in)], [file/bukkit (world)]

Plugins: Essentials, SkinsRestorer, WorldEdit, WorldEditSelectionVisualizer

Just migrated alt server to reproduce a crash, experienced it as well on main server. "SkinsRestorer" is only plugin that is used across both servers.

Actions to reproduce (if known)

Find shipwreck or underwater ruins chest that contains map and right click it. Seems like spamming right click is more effective to cause crash. Usually it's just slightly lagging with single click.

https://youtu.be/0p4lbi9iHr8

Paper version

1.20 Build 9

This server is running Paper version git-Paper-9 (MC: 1.20) (Implementing API version 1.20-R0.1-SNAPSHOT) (Git: 3722877) Previous version: git-Paper-468 (MC: 1.19.4)

Other

While experiencing crash by opening crate with single click on main server this chest was containing items except a treasure map, it became just an Empty map but with name "Treasure map" on it. But after recreating and spamming this chest it wasn't containing any items in it.

Clicking on chests with non previously generated loot without a map doesn't do anything

electronicboy commented 1 year ago

This is a vanilla issue, interacting with a treasure map causes a scan of like 10.5k chunks, this isn't really something that can be fixed by us; https://paper-chan.moe/paper-optimization/ ctrl-f "treasure"

no10884 commented 1 year ago

this isn't really something that can be fixed by us

Sorry, I'm not that knowledgeable in coding and development, but at least is it possible to limit this scan to one time? Because looks like spamming makes a lot of requests causing crash instead of small lag

electronicboy commented 1 year ago

I really doubt that that is the case unless you've configured the server in such a manner, interacting with the chest will cause it to process the loot table, and then that info is destroyed, and it's just a normal chest

liorsl commented 1 year ago

@electronicboy This happens to me as well, only plugin is voice chat and on default configuration:

21:04:12 ERROR: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH - git-Paper-18 (MC: 1.20.1) --- 21:04:12 ERROR: The server has not responded for 10 seconds! Creating thread dump

21:04:12 ERROR: Server thread dump (Look for plugins here before reporting to Paper!): 21:04:12 ERROR: Ticking entity: minecraft:player, entity class: net.minecraft.server.level.EntityPlayer 21:04:12 ERROR: Entity status: removed: false, valid: true, alive: true, is passenger: false 21:04:12 ERROR: Entity UUID: 7349b311-43be-4929-b66a-a55904ee3662 21:04:12 ERROR: Position: world: 'world' at location (11284.515294901421, 39.0, 10925.890195470052)

21:04:12 ERROR: Entity AABB: AABB[11284.2152948895, 39.0, 10925.590195458131] -> 11284.815294913342, 40.799999952316284, 10926.190195481973: Total packets processed on the main thread for all players: 1178172

21:04:12 ERROR: Current Thread: Server thread 21:04:12 ERROR: PID: 29 | Suspended: false | Native: false | State: RUNNABLE

21:04:12 ERROR: net.minecraft.world.level.levelgen.NoiseChunk$$Lambda$6904/0x00000008021db340.apply(Unknown Source)

21:04:12 ERROR: net.minecraft.world.level.levelgen.DensityFunctions$w$$Lambda$5227/0x0000000801c4c8b0.visit(Unknown Source)

21:04:12 ERROR: net.minecraft.util.CubicSpline$e$$Lambda$5228/0x0000000801c4cad8.apply(Unknown Source)

21:04:12 ERROR: net.minecraft.world.level.levelgen.structure.StructureCheck$$Lambda$7745/0x000000080230c000.get(Unknown Source)

21:04:12 ERROR: net.minecraft.world.level.storage.loot.functions.LootItemFunctions$$Lambda$4496/0x00000008019f8000.apply(Unknown Source)

21:04:12 ERROR: net.minecraft.world.level.storage.loot.functions.LootItemFunction$$Lambda$6816/0x00000008021bb338.accept(Unknown Source)

21:04:12 ERROR: net.minecraft.network.protocol.PlayerConnectionUtils$$Lambda$6576/0x0000000802159ab8.run(Unknown Source)

21:04:12 ERROR: net.minecraft.server.MinecraftServer$$Lambda$4685/0x0000000801a3b830.run(Unknown Source)

21:04:12 ERROR: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH ---

lordofpipes commented 1 year ago

What would cause no chests to be found when its doing the treasure chest search? This has been happening much more often in 1.20, and I'm wondering if treasure chests are no longer generating or if something about the search is broken.

electronicboy commented 1 year ago

The thing often breaks on upgrades due to a mismatch between the old and the new algo as stuff slowly changes

On Sat, 1 Jul 2023, 22:19 lordofpipes, @.***> wrote:

What would cause no chests to be found when its doing the treasure chest search? This has been happening much more often in 1.20, and I'm wondering if treasure chests are no longer generating or if something about the search is broken.

— Reply to this email directly, view it on GitHub https://github.com/PaperMC/Paper/issues/9319#issuecomment-1616135671, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMAZGBOIKU2O5E5RPREJ3XOCH7NANCNFSM6AAAAAAZDNJLOM . You are receiving this because you were mentioned.Message ID: @.***>

PaperMC / Paper