search

PaperMC / Paper

The most widely used, high performance Minecraft server that aims to fix gameplay and mechanics inconsistencies
https://papermc.io/
Other
9.98k stars 2.32k forks source link

Brand payload packets don't work #9904

Open ghost opened 1 year ago

ghost commented 1 year ago

Expected behavior

Client brand packets should contain their brand.

Observed/Actual behavior

After recently updating paper, it seems like somehow brand packets are deserialized wrongly to have unknown brand payloads instead of net.minecraft.network.protocol.common.custom.BrandPayload, the result is that the .data() is an empty string instead of the client brand.

Steps/models to reproduce

Listen for payload packets

Plugin and Datapack List

Protocollib (for listening to the packets), i am just calling .getHandle() to get the raw NMS packet though

Paper version

This server is running Paper version git-Paper-"1865625" (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 1865625) You are 3 version(s) behind Download the new version at: https://papermc.io/downloads/paper Previous version: git-Paper-"4b0bc74" (MC: 1.20.2)

Other

No response

Machine-Maker commented 1 year ago

Yeah, upstream just decided to remove the custom handling and handle everything as unknown.

ghost commented 1 year ago

Yeah, upstream just decided to remove the custom handling and handle everything as unknown.

Damn, what can be done to fix this?

My current workarodund is player.getClientBrandName()

Sytm commented 1 year ago

There is #9863 as a possible approach to solve this issue

ghost commented 1 year ago

oh yeah, isn't the entire on plugin message received thing broken?