search

PaperMC / Paperclip

Bootstrap utility and launcher for the Paper Minecraft server
MIT License
120 stars 51 forks source link

Add command line option to only patch the server #8

Closed mikroskeem closed 7 years ago

mikroskeem commented 7 years ago

Title says it all. ¯\_(ツ)_/¯

aikar commented 7 years ago

This belongs at the paper repo, not here...

aikar commented 7 years ago

What is your use case? this already exists even: https://github.com/PaperMC/Paper/blob/master/paper#L44

just run paper patch

zachbr commented 7 years ago

He doesn't want to constantly compile from source, he wants to be able to download a built paperclip jar file and just have that do the patch then exit.

It does belong here, it is a valid use case.

Edit: and while I'm here, here are the concerns with this patch

04:25 @DemonWav it's supposed to, from the user's perspective, "be" the server 04:25 @DemonWav so we can't start accepting command line arguments in paperclip 04:25 @DemonWav since all commandline arguments are simply passed to the server itself 04:26 @DemonWav in this particular instance it would be fine, since this argument would prevent the server from ever starting 04:26 @DemonWav but it's a principles sort of thing 04:27 @DemonWav so instead we could use a property 04:27 @DemonWav paperclip.patchonly would work fine

@mikroskeem please make the necessary changes when you are available to do so, thanks.

mikroskeem commented 7 years ago

I am behind computer in 10pm (Europe/Tallinn TZ).

Using system property is better option, yes. I didn't think about that. :+1:

What is your use case?

Look at my project Orion :)

mikroskeem commented 7 years ago

Going to open new pull request, because I messed up my repository