PaperMC / Starlight

Rewrites the light engine to fix lighting performance and lighting errors
Other
1.27k stars 136 forks source link

Large shadows after blowing up lots of TNT #165

Closed AverageTurtle closed 1 year ago

AverageTurtle commented 2 years ago

This could be a compatibility issue sense the server is running geyser! It is a fabric 1.19.2 server (fabric 0.14.10)

Mods on server:

2022-11-08_11 18 06

Spottedleaf commented 1 year ago

This is likely a result of the behavior in 1.19 that sends light data directly when the number of blocks broken in a chunk section exceeds 64. This is specific to how Vanilla manages block syncing to the client, so nothing to do with Starlight. I used to have some fixes that would alleviate the issue slightly, but I dropped them and didn't bother to improve them as it's really a Vanilla problem unrelated to the lighting engine.

However, in 1.20.something they removed the behavior I described which should actually fix the issue. So the solution would be to update.

If you can produce the behavior on 1.20.2 I can look at fixing it, but in my experience in blowing up large amounts of TNT it's not an issue.