[Future] Tracking 1.16 changes

[Xernium]

This Pull-request is meant to be merge-ready when 1.16 gets released so a usable Bungeecord can be obtained ASAP. The changes in this PR will get lost when Bungeecord gets updated to support 1.16, that is intentional. This is just meant to maybe make @electronicboy s life a little easier ;)

[compieter-gh]

Thank you very much for this cause now i can have 1.16 snapshot support with vanillacord hope it works

[compieter-gh]

Confimation it works with vanillacord and viaversion thanks you very much @Xernium

[Xernium]

I should mention that for now you can find builds of this fork at https://jenkins.krusic22.com/job/Travertine-Xernium/ (kindly provided by @krusic22)

[Xernium]

I should add that I'm only tracking all snapshots so far because of accuracy reasons. The unused or obsolete ones can be flattened out rather easily and I will do so before release

[mio-19]

This won't make @electronicboy s life a little easier, but this maybe make @md-5 s life a little easier

[Xernium]

@tsao-chi I doubt it; last time @electronicboy hacked together a working bungeecord well ahead of time md-5 was ready with it on his side

[Xernium]

That said; I am open to it. I’ll PR my changes th BungeeCord and see what he has to say;

[astei]

@Xernium You'll get the cold shoulder, with him saying that "updates are handled internally" and your PR will be closed. I didn't need to open a PR to demonstrate this - there are several examples of this.

[Xernium]

@astei I wasn’t gonna PR to experience that, I know very well what the outcome would be sadly

[Xernium]

That said who cares in the end- I’ll open my PR and get shut down. I knew that that’s gonna happen from the moment I sent that message. But at least I tried then

[Xernium]

Update: Well I got my answer in IRC and I’ll leave it at that. I won’t attempt to contribute to bungeecord directly again. But oh well at least I showed good faith ¯_(ツ)_/¯

[krusic22]

You could move the PR to Travertine, as that got 1.15 support before upstream.

[astei]

...this is literally a Travertine PR.

[krusic22]

Thanks for reminding me.

[aikar]

I would rather be PR'd to Waterfall. Not all of us use Travertine.

Then Travertine will get it from WF.

[TychoWerner]

Does this need changes when 20w18a comes out or whatever version for that matter or will the previous version still work?

[Xernium]

@TychoWerner Since the snapshots are a highly dynamic element; Yes of course it will change. That’s what this pull request is for. If someone had to do one thing to make all future snapshots work then we wouldn’t be here atm. We can’t exactly predict what Mojang will do to that level. So yes there are gonna be updates and yes stuff is going to break (most likely)

[Xernium]

Side note; I will move this to Waterfall during the coming weekend as per @aikar s suggestion

[JRoy]

@aikar Waterfall has never supported protocols before upstream. These protocols have always been done in Travertine (dbe27f380f23a37386615e317cc1e5a78a65e636, 32c100ed0360addab7421554ee81c86a018e27e1, ac8e757b85208996874605ed305cfdad12d6c3fd). @Xernium for that reason I say keep this here unless aikar or some other member of the paper team replies.

[Xernium]

@JRoy It’d help if you scrolled up in the conversation a bit ;)

[TychoWerner]

@TychoWerner Since the snapshots are a highly dynamic element; Yes of course it will change. That’s what this pull request is for. If someone had to do one thing to make all future snapshots work then we wouldn’t be here atm. We can’t exactly predict what Mojang will do to that level. So yes there are gonna be updates and yes stuff is going to break (most likely)

Thanks for your reply. I was looking at your latest commit (https://github.com/PaperMC/Travertine/pull/120/commits/6af17c8eb97a99cd51d7262c2ed78345a4f17f10) and it seemed "just" adding 20w17a on certain points which to my eyes seems to be easily be planned ahead (and even looked like it already did with FUTURE_SNAPSHOT).

Do a lot of changes have to be made to support the newer versions, I understand that changes have to be made when things to players, chat, and other server things change.

But new blocks and a couple of of new mobs they don't have affect as it has nothing to do with Bungeecord right? Or am I seeing that wrong?

Thanks for making this available, it helps me bring together multiple versions of servers with also snapshots. We play a survival world and can now easily get to a creative testing world 👍

[compieter-gh]

@Xernium i got an issue with players being disconnected and it says that they where sent too an fallback server while the server they were on didn't go down i am using the last buid as of this moment and have viaversion on my proxy along with someother plugins that shoudn't affect this. hope you can help with this. it's only with 1.16

[compieter-gh]

am atm looking if this is an 1.16 viaversion issue by moving them too the servers intead of the proxy itself cause had more problems with viaversion though it shoudn't interfere with this

[Xernium]

@TheCompieter I don’t test with ViaVersion especially since it wasn’t updated yet when I pushed this update. It worked on a vanilla snapshot server. I’ll investigate and look into it.

[compieter-gh]

thanks if you need any more specific information say so.

[compieter-gh]

also when throwing out an fishing line it doesn't show the line or dobber but does in single player and this is without viaversion and with viaversion.

[Xernium]

@TheCompieter The fishing issue might be due to an entity rewriter being broken. I'll have to look at it. Also I can't reproduce your issue. I tried it with a network that has a 1.15.2 paper server with ViaVersion and a Vanillacord 20w17a server. Is there a specific trigger to the issue?

[Xernium]

Side note; a productive conversation here using comments isn't going to be easy. If you use Discord please @Five#0001 me on the ViaVersion or on the PaperMC Discord server, that could speed this up a lot

[compieter-gh]

@TheCompieter The fishing issue might be due to an entity rewriter being broken. I'll have to look at it. Also I can't reproduce your issue. I tried it with a network that has a 1.15.2 paper server with ViaVersion and a Vanillacord 20w17a server. Is there a specific trigger to the issue?

No it's random and no error as far as i know i am now just using it without viaversion and if it still happens i will let you know.

Side note; a productive conversation here using comments isn't going to be easy. If you use Discord please @Five#0001 me on the ViaVersion or on the PaperMC Discord server, that could speed this up a lot

Okay i will do that my discord is ComPieter#5082

[Xernium]

Branch will be reworked in favour of https://github.com/PaperMC/Waterfall/pull/494