search

PaperMC / Waterfall

BungeeCord fork that aims to improve performance and stability.
https://papermc.io
MIT License
743 stars 297 forks source link

Update Java version in GitHub Actions #707

Closed Luccboy closed 2 years ago

Luccboy commented 2 years ago

As Minecraft 1.18 requires Java 17, I think we should also use Java 17 to build Waterfall.

montlikadani commented 2 years ago

You may also want to update the version of setup-java and checkout actions to the newest one.

Name Newest version
setup-java v2.3.1
checkout v2.4.0
Luccboy commented 2 years ago

You may also want to update the version of setup-java and checkout actions to the newest one.

Name Newest version setup-java v2.3.1 checkout v2.4.0

Thx, done

Janmm14 commented 2 years ago

You may also want to update the version of setup-java and checkout actions to the newest one. Name Newest version setup-java v2.3.1 checkout v2.4.0

Thx, done

These actions use tags for release management to update @v2 to the latest 2.x version. Therefore it is not good to pinpoint these actions to a certain version this way, please revert it.

If you watch the action logs ("Set up job" part), you can see the SHA of checkout v2 and v2.4.0 for example are identical currently: https://github.com/PaperMC/Waterfall/runs/4345029848?check_suite_focus=true https://github.com/PaperMC/Waterfall/runs/4347010510?check_suite_focus=true

Xernium commented 2 years ago

@Janmm14 is correct. Please revert that for the PR to be considered, thanks.

Luccboy commented 2 years ago

Thank you for pointing this out to me, I reverted the changes.