PaperMC / Waterfall

BungeeCord fork that aims to improve performance and stability.
https://papermc.io
MIT License
742 stars 297 forks source link

ServerKickEvent isn't being fired. #758

Open sasi2006166 opened 2 years ago

sasi2006166 commented 2 years ago

I was messing around for testing the new version (1.19) and after some accurate test(s) I'm here to report that ServerKickEvent isn't started if a connected sub_server crashes (or just runs /stop).

Apparently, the issue is gone if /kick (or /ban) and /restart are being executed. Another thing I saw after some debugging is that the proxy is using PlayerDisconnectEvent if a sub_server goes down (even in /stop) instead of kicking the player.

The issue is here after 1.19 BungeeCord's update.

Waterfall version: 1.19-496 Spigot instances: Paper 1.19-13

sasi2006166 commented 2 years ago

Bump, someone?

FrancyPro commented 2 years ago

boh, write on paper discord for support

sasi2006166 commented 2 years ago

They did a total mess with this crap 1.19 update, hate it.

Xernium commented 2 years ago

Can you reproduce this issue on Bungeecord itself? If yes please move this to upstream. The update we did wasn’t any higher quality than the Bungeecord update, simply because Waterfall is based on Bungeecord. I don’t really see how Waterfall could break that event though

sasi2006166 commented 2 years ago

BungeeCord's situation is even worse, the kick isn't working anymore. On waterfall the issue is partially there, for example in some setups works and on some not, but the issue is there from 1.19 update.