search

PaperMC / Waterfall

BungeeCord fork that aims to improve performance and stability.
https://papermc.io
MIT License
742 stars 297 forks source link

Use Velocity VarIntFrameDecoder #783

Closed xism4 closed 1 year ago

xism4 commented 1 year ago

Velocity provides a pretty frame decoder that could be used without any problem in Waterfall (Also works on java 8)

After debating for some time, I want to continue improving Waterfall to the best of my knowledge. Since I work with it and many people are still using it. And if anyone wonders why if Velocity already has it? The same question should be asked with other patches that Waterfall uses from Velocity as well.

Janmm14 commented 1 year ago

Better in terms of what? Why create unneccessary additional object? Did you create and run benchmarks?

Additionally there is a licensing problem, as in Waterfall is MIT while the code you want to insert here is GPL. Or is that code in Velocity written by you originally?

xism4 commented 1 year ago

Better in terms of what? Why create unneccessary additional object? Did you create and run benchmarks?

Additionally there is a licensing problem, as in Waterfall is MIT while the code you want to insert here is GPL. Or is that code in Velocity written by you originally?

I was talking to a dev from velocity, and he told me that if I followed the license, yes i could open this pull request.

Additionally I have done a couple of tests and it has been a little faster with the new patch. Above all, a much cleaner source

Janmm14 commented 1 year ago

Better in terms of what? Why create unneccessary additional object? Did you create and run benchmarks? Additionally there is a licensing problem, as in Waterfall is MIT while the code you want to insert here is GPL. Or is that code in Velocity written by you originally?

I was talking to a dev from velocity, and he told me that if I followed the license, yes i could open this pull request.

Additionally I have done a couple of tests and it has been a little faster with the new patch. Above all, a much cleaner source

You did not handle the GPL license correctly.

For inclusion of GPL code in a project, the complete project has to be released under GPL license.

This would mean that Waterfall has to change its license from MIT to GPL and may not be published under MIT license anymore.

You should talk with a maintainer of Waterfall before you do so. As I am not sure whether a change to a far more restrictive license for Waterfall is desired here.

xism4 commented 1 year ago

This would mean that Waterfall has to change its license from MIT to GPL and may not be published under MIT license anymore.

I talked with Five and i understond this, but ill wait @electronicboy, and let's see.

xism4 commented 1 year ago

I will close this due multiple opinions with really diferent points.